sensu / sensu-go-chef

Chef Library Cookbook for Sensu Go

https://sensu.io

MIT License

11 stars 22 forks source link

Sensu-Go-Agent support for windows platform #49

Closed derekgroh closed 5 years ago

derekgroh commented 5 years ago

Pull Request Checklist

46 - Add support for installing Sensu Agent MSI on Windows

General

[X] Update Changelog following the conventions laid out here
[X] Update README with any necessary configuration snippets
[X] Cookstyle (rubocop) passes
[X] Foodcritic passes
[X] Rspec (unit tests) passes
[X] Inspec (integration tests) passes

New Features

[X] Added a Testing Artifact as either an automated test or a manual artifact on the PR.
[X] Added documentation for it to the README.md

Purpose

Allows cookbook to handle installation and configuration of the Windows (5.10.0) MSI.

Known Compatibility Issues

Long term implementation does not support using the latest version, until a package mechanism is created. This will most likely occur via Chocolatey in the future.

webframp commented 5 years ago

Thanks for adding this @derekgroh Windows support is important here. I’ll look at the options for ci testing and review a little more in detail tomorrow.

derekgroh commented 5 years ago

Anything I can do to further assist?

majormoses commented 5 years ago

@webframp travis supports windows in limited capacity I think it might be easier/better to simply have it handled by appveyor or similar with more broad windows support, here is an example setup: https://github.com/chef-cookbooks/windows/blob/master/appveyor.yml

webframp commented 5 years ago

@majormoses I’m a fan of adding .gitattributes for cross platform repo work, sounds reasonable for this case.

webframp commented 5 years ago

I’m interested in any input from @cwjohnston or @amdprophet for how they want to handle windows versions and the release process there.

derekgroh commented 5 years ago

Added support for :remove action Added appveyor files (not sure how to get this into a pipeline)

webframp commented 5 years ago

I’d be ok with appveyor and could set it up, but would want to check with any preference from Sensu org in general for Windows ci first

majormoses commented 5 years ago

@webframp they use it in core for building their packages: https://github.com/sensu/sensu-go/blob/5.10.1/.appveyor.yml

cwjohnston commented 5 years ago

I've added this project to our AppVeyor account; I'm thinking the next commit to this branch should kick off a test there.

webframp commented 5 years ago

Thanks @cwjohnston !

derekgroh commented 5 years ago

@cwjohnston Who's the goto to ask about appveyor setup? I seem to be missing something on the lint tests in the test environment, but they are successful locally.

webframp commented 5 years ago

Looks like appveyor and travis have different cookstyle versions:

Will be good to keep those consistent.

derekgroh commented 5 years ago

Should we favor TravisCI linting and just use appveyor for integration testing?

majormoses commented 5 years ago

Should we favor TravisCI linting and just use appveyor for integration testing?

I think that makes sense

majormoses commented 5 years ago

@derekgroh you rock, thank you for this!