search

sensu / sensu-go-chef

Chef Library Cookbook for Sensu Go
https://sensu.io
MIT License
11 stars 22 forks source link

Sensu-Go-Ctl support for windows platform #59

Closed derekgroh closed 4 years ago

derekgroh commented 5 years ago

Pull Request Checklist

50

General

New Features

Purpose

Provide a method for windows entities to install and configure the Sensuctl.exe application.

Known Compatibility Issues

This may be held until packaging for Sensuctl.exe is presented in a more Windows friendly manner avoiding the additional steps to obtain the exe, which would require modification to the resource and unit tests.

webframp commented 4 years ago

@derekgroh overall I'm 👍 for this, just a small question. Thanks for adding the windows support here!

derekgroh commented 4 years ago

So a limitation of two different testing tools is there is no method through appveyor to test ctl recipes as it requires a converged server to make a call against. (Unless there is a public instance Sensu runs that we could make the call against?)

Should this be addressed as part of this PR or addressed later as the tooling allows?

webframp commented 4 years ago

@derekgroh this is getting pretty big at this point so I'd like to be able to merge for you soon. Can you explain the appveyor problem a little more? Would there be a problem just using the same single instance on appveyor to run as the server + ctl for tests?

derekgroh commented 4 years ago

@webframp Sensuctl suite tests a connection to a backend to confirm it is configured correctly, unless there is a way to mock it without a backend being available. Otherwise appveyor has no method to test this suite, because it can not launch a backend to test against. I can explain further in Slack if you want.

webframp commented 4 years ago

@derekgroh Added #68 to remember to come back and address this testing limitation.