add support for PostgresConfig - Githubissues

sensu / sensu-go-chef

Chef Library Cookbook for Sensu Go

https://sensu.io

MIT License

11 stars 22 forks source link

add support for PostgresConfig #70

Closed cwjohnston closed 4 years ago

cwjohnston commented 4 years ago

Pull Request Checklist

Is this in reference to an existing issue?

General

[x] Update Changelog following the conventions laid out here
[x] Update README with any necessary configuration snippets
[x] Cookstyle (rubocop) passes
[x] Foodcritic passes
[x] Rspec (unit tests) passes
[ ] Inspec (integration tests) passes

New Features

[x] Added a Testing Artifact as either an automated test or a manual artifact on the PR.
[x] Added documentation for it to the README.md

Purpose

Closes #67

cwjohnston commented 4 years ago

LGTM

What are your thoughts about adding an actual integration test with postgres?

I've added integration tests in 1939bc2 which pass using kitchen-vagrant, but fail under kitchen-dokken due to locale issues.

Because of the relative complexity of changes needed to enable consistent locales across docker containers for multiple distributions, I'm thinking that I'll remove actual installation of postgresql in the next commit.