sensu / sensu-go-chef

Chef Library Cookbook for Sensu Go
https://sensu.io
MIT License
11 stars 22 forks source link

Added init action to sensu-backend to fix functionality added in 5.16.0. #78

Closed kovukono closed 4 years ago

kovukono commented 4 years ago

Pull Request Checklist

Is this in reference to an existing issue? Yes, Issue #77

General

New Features

Purpose

516.0 no longer adds a default username and password, and they need to be configured or the sensuctl resource will fail.

Known Compatibility Issues

kovukono commented 4 years ago

I've been able to verify that this works for Linux, but haven't for Windows. As for the Travis checks not passing, chefdk doesn't appear to be available from an apt repo, and the official page is saying to grab it from there and download it. Cookstyle doesn't pass, but a large majority of the issues are related to using 'platform?' instead of "node['platform']", which wasn't available in 12.5 to my knowledge.

webframp commented 4 years ago

@kovukono Some updates for ci are proposed in #75 that I hope should help with the chefdk issues.

kovukono commented 4 years ago

@majormoses, @derekgroh would it be possible to have another look at this PR?

derekgroh commented 4 years ago

You may want to introduce #75 fixes to see if that passes the travis build. Appveyor test will not need to be passed for your PR.

kovukono commented 4 years ago

@derekgroh Appveyor isn't working, but pulling in #75 and making some changes to the test recipes does have the Travis tests working now.

majormoses commented 4 years ago

I am targeting a release asap, once I get a review and it will be 0.2.0 unless someone disagrees.