Closed kovukono closed 4 years ago
I've been able to verify that this works for Linux, but haven't for Windows. As for the Travis checks not passing, chefdk doesn't appear to be available from an apt repo, and the official page is saying to grab it from there and download it. Cookstyle doesn't pass, but a large majority of the issues are related to using 'platform?' instead of "node['platform']", which wasn't available in 12.5 to my knowledge.
@kovukono Some updates for ci are proposed in #75 that I hope should help with the chefdk issues.
@majormoses, @derekgroh would it be possible to have another look at this PR?
You may want to introduce #75 fixes to see if that passes the travis build. Appveyor test will not need to be passed for your PR.
@derekgroh Appveyor isn't working, but pulling in #75 and making some changes to the test recipes does have the Travis tests working now.
I am targeting a release asap, once I get a review and it will be 0.2.0 unless someone disagrees.
Pull Request Checklist
Is this in reference to an existing issue? Yes, Issue #77
General
[X] Update Changelog following the conventions laid out here
[X] Update README with any necessary configuration snippets
[ ] Cookstyle (rubocop) passes
[X] Foodcritic passes
[ ] Rspec (unit tests) passes
[ ] Inspec (integration tests) passes
New Features
[ ] Added a Testing Artifact as either an automated test or a manual artifact on the PR.
[X] Adedd documentation for it to the
README.md
Purpose
516.0 no longer adds a default username and password, and they need to be configured or the sensuctl resource will fail.
Known Compatibility Issues