Added Active Directory integration.

sensu / sensu-go-chef

Chef Library Cookbook for Sensu Go

https://sensu.io

MIT License

11 stars 22 forks source link

Added Active Directory integration. #91

Closed kovukono closed 4 years ago

kovukono commented 4 years ago

Pull Request Checklist

Is this in reference to an existing issue?

Yes, #81

General

[X] Update Changelog following the conventions laid out here
[X] Update README with any necessary configuration snippets
[ ] Cookstyle (rubocop) passes
[X] Foodcritic passes
[X] Rspec (unit tests) passes
[X] Inspec (integration tests) passes

New Features

[X] Added a Testing Artifact as either an automated test or a manual artifact on the PR.
[X] Adedd documentation for it to the README.md

Purpose

Allow the cookbook to be used to create an Active Directory resource.

Known Compatibility Issues

kovukono commented 4 years ago

Currently investigating what might be causing the confusion in the names of resources. Strangely enough, this branch was used to successfully integrate an active directory already, but was using Chef 14, not 16.

kovukono commented 4 years ago

I've been able to narrow it down to an issue that rises in Chef Infra 16.2.2, the current release, but not the stable release of Chef Infra 16.1.16. In order to fix this (since we don't know what the changes are for 16.2.2 are since we don't have release notes for non-stable Chef releases), I'd like to add the "channel: stable" attribute to the provisioner in the kitchen. @majormoses @derekgroh Would this be an issue?

kovukono commented 4 years ago

I'm not sure exactly why the build isn't showing up here, but it's currently working for all but Cookstyle, due to an issue with the inclusion of the ChefSpec coverage. https://travis-ci.org/github/sensu/sensu-go-chef/builds/694743839

It appears it's now using a newer version of Cookstyle, and that's showing warnings for things that were previously ignored. I removed the testing for Ubuntu 14.04 since it's no longer a valid platform, and made the CentOS version a generic 7.6 so that we don't have the issue again where a specific version breaks when it's deprecated from Fauxhai.