Expanded available entity attributes. - Githubissues

sensu / sensu-go-chef

Chef Library Cookbook for Sensu Go

https://sensu.io

MIT License

11 stars 22 forks source link

Expanded available entity attributes. #93

Closed kovukono closed 4 years ago

kovukono commented 4 years ago

Pull Request Checklist

Is this in reference to an existing issue? #73

General

[X] Update Changelog following the conventions laid out here
[X] Update README with any necessary configuration snippets
[x] Cookstyle (rubocop) passes
[x] Foodcritic passes
[x] Rspec (unit tests) passes
[x] Inspec (integration tests) passes

New Features

[X] Added a Testing Artifact as either an automated test or a manual artifact on the PR.
[X] Added documentation for it to the README.md

Purpose

Add additional attributes for full configuration of entities.

Known Compatibility Issues

kovukono commented 4 years ago

Sorry about the extra pushes, was trying to keep the commit clean while fixing the issues. Cookstyle is still unhappy with chef-spec.

derekgroh commented 4 years ago

LGTM, if you want to work on some of the cookstyle that would be welcome.

Otherwise, add to the current .rubocop and we'll work on it as a #TODO.