search

sensu / sensu-go-graphite-handler

MIT License
4 stars 5 forks source link

Classic extension parity support #7

Closed nikkictl closed 4 years ago

nikkictl commented 4 years ago

Added a number of features for parity support of the Classic extension, see changelog for full list.

nikkictl commented 4 years ago

Looks like the tests passed but the linter failed! Maybe you could give it a rerun to see if that resolves the issue @nixwiz?

ERRO Deadline exceeded: try increase it by passing --deadline option 
The command "golangci-lint run --disable-all --enable=vet --enable=ineffassign --enable=goconst --tests ./..." exited with 4.
36.16s$ go test -v -race ./...
go: extracting golang.org/x/net v0.0.0-20200114155413-6afb5195e5aa
go: downloading google.golang.org/genproto v0.0.0-20191009194640-548a555dbc03
go: finding github.com/robertkrimen/otto latest
go: finding github.com/robertkrimen/otto/parser latest
go: extracting google.golang.org/genproto v0.0.0-20191009194640-548a555dbc03
go: downloading gopkg.in/sourcemap.v1 v1.0.5
go: extracting gopkg.in/sourcemap.v1 v1.0.5
=== RUN   TestExecuteHandler
--- PASS: TestExecuteHandler (0.00s)
=== RUN   TestMain
ok      github.com/nixwiz/sensu-go-graphite-handler 1.027s
The command "go test -v -race ./..." exited with 0.
nixwiz commented 4 years ago

@nikkixdev failed again on a re-run.

$ golangci-lint run --disable-all --enable=vet --enable=ineffassign --enable=goconst --tests ./...
ERRO Running error: context loading failed: failed to load program with go/packages: go [list -e -json -compiled=true -test=true -export=false -deps=true -find=false -- ./...]: signal: killed: go: finding github.com/sensu/sensu-go v5.10.1+incompatible
nikkictl commented 4 years ago

@nixwiz I ran the following on my local setup with no error. Can you reproduce? Could just be a Travis error.

install:
- curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh |
  sh -s -- -b $(go env GOPATH)/bin v1.17.1
script:
- golangci-lint run --disable-all --enable=vet --enable=ineffassign --enable=goconst
  --tests ./...
- go test -v -race ./...
nikkictl commented 4 years ago

Happy to migrate the project to Github Actions if you want to kill Travis altogether!

nixwiz commented 4 years ago

It's definitely Travis wonkiness. It errors on a different module each time it fails.

nixwiz commented 4 years ago

I updated .travis.yml in master to use a newer version of golangci-lint and builds seem to be working better on Travis. Can you rebase or merge that into your PR?