Platform family not being populated on agents deployed on Alma linux.

asachs01 commented 1 year ago

Expected Behavior

When deploying agents on Alma Linux (or even Rocky), I expect that agents will report as the RHEL family.

Current Behavior

When deploying agents on Alma Linux, agents aren't reported as being part of the RHEL family:

Alma Linux Entity Info

```yaml type: Entity api_version: core/v2 metadata: created_by: agent labels: sensu.io/managed_by: sensu-agent name: sensu-almalinux namespace: default spec: deregister: false deregistration: {} entity_class: agent last_seen: 1679930991 redact: - password - passwd - pass - api_key - api_token - access_key - secret_key - private_key - secret sensu_agent_version: 6.9.2 subscriptions: - entity:sensu-almalinux system: arch: amd64 cloud_provider: "" hostname: sensu-centos libc_type: glibc network: interfaces: - addresses: - 127.0.0.1/8 name: lo - addresses: - 10.0.2.15/24 mac: 08:00:27:69:6d:40 name: eth0 - addresses: - 192.168.156.70/24 - fe80::a00:27ff:fe58:885f/64 mac: 08:00:27:58:88:5f name: eth1 os: linux platform: almalinux platform_version: "8.7" processes: null vm_role: guest vm_system: vbox user: agent ```

Possible Solution

We'll probably need to enhance what we're doing in https://github.com/sensu/sensu-go/blob/develop/6/system/system.go#LL48C6-L48C6 so that we recognize Alma/Rocky as RHEL family OS's.

Steps to Reproduce (for bugs)

Deploy an agent on Alma 2.sensuctl entity info sensu-almalinux

Context

Assets aren't being deployed correctly on these OS's. Please see internal ref https://secure.helpscout.net/conversation/2195515739/31152?folderId=5845954.

Your Environment

Sensu version used (sensuctl, sensu-backend, and/or sensu-agent): 6.9.1
Installation method (packages, binaries, docker etc.): Packages
Operating System and version (e.g. Ubuntu 14.04): Alma Linux 8

asachs01 commented 1 year ago

@fguimond can we get this added to a soonish release? It's presently blocking asset downloads on the internal ref linked above.

ccressent commented 1 year ago

Suggestion: it's probably as simple as upgrading the version of gopsutil we are using. Alma Linux is put in the RHEL family in newer versions of the library than the one we are currently using: https://github.com/shirou/gopsutil/blob/master/host/host_linux.go#L295-L296

ccressent commented 1 year ago

@asachs01 Feel free to try the build artifacts from that PR above; that should solve the issue.

ccressent commented 1 year ago

This is fixed by:

This will be included in 6.10.

sensu / sensu-go