sensu / sensu-go

Simple. Scalable. Multi-cloud monitoring.
https://sensu.io
MIT License
1.02k stars 176 forks source link

Use asset build with most specific filters #4990

Closed amdprophet closed 1 year ago

amdprophet commented 1 year ago

What is this change?

Updates asset.FilteredManager to evaluate all asset build filters and returns the asset build with the most specific (highest number of filters) matching the entity. This is a breaking change as it can alter which asset build is installed on existing clusters.

Why is this change necessary?

Closes https://github.com/sensu/sensu-go/issues/3655 Closes https://github.com/sensu/sensu-go/issues/4455

Does your change need a Changelog entry?

Yes.

Do you need clarification on anything?

No.

Were there any complications while making this change?

No.

Have you reviewed and updated the documentation for this change? Is new documentation required?

The docs should be updated to describe this behaviour. https://github.com/sensu/sensu-docs/issues/4185

How did you verify this change?

I used TDD to define the behaviour before I made the change. The tests should be sufficient.

Is this change a patch?

No.