search

sensu / sensu-go

Simple. Scalable. Multi-cloud monitoring.
https://sensu.io
MIT License
1.02k stars 176 forks source link

Improvement threshold annotations format (for 6.x) #5014

Closed jadiunr closed 1 year ago

jadiunr commented 1 year ago

What is this change?

This PR adds annotations to the event even if the threshold check is normal. In addition, the format is changed so that the min-max range can be output in a single annotation.

See #4987

Why is this change necessary?

Adding the threshold annotation when normal will allow to ensure that the thresholds are normal when notifying some communication platform of the Event. This change also makes it easier to ensure that the threshold checks are working correctly.

Does your change need a Changelog entry?

Yes, required as Added and Changed.

Do you need clarification on anything?

This PR is for Sensu Go 6.x (develop/6 branch).

Were there any complications while making this change?

Have you reviewed and updated the documentation for this change? Is new documentation required?

This section Add event annotations based on metric threshold evaluation may need to be rewritten.

How did you verify this change?

Setup a test environment using output_metric_thresholds and verified that the annotations have been added.

Is this change a patch?

No.

echlebek commented 1 year ago

Sorry, but we can't accept this PR as it could potentially break workflows. However, the sibling PR for main is accepted.