search

sensu / sensu-go

Simple. Scalable. Multi-cloud monitoring.
https://sensu.io
MIT License
1k stars 178 forks source link

Add support for conditional requests #5016

Closed echlebek closed 1 year ago

echlebek commented 1 year ago

This commit adds support for the conditional HTTP headers If-Match and If-None-Match. It also changes the way ETag is produced for all resources.

Clients can use If-Match and If-None-Match in the way described by RFC 7232 when making requests.

Closes #4341

echlebek commented 1 year ago

@c-kruse this isn't fully complete yet. I need to add test coverage in a few places. But I wanted to get this onto your reviewing docket as it's quite a lot of changes, more than I was hoping for tbh.

echlebek commented 1 year ago

@c-kruse Probably good enough to start reviewing, though I suspect there might be some missing pieces. I'm reviewing myself as well.

echlebek commented 1 year ago

I've done quite a bit of manual end to end testing on this now, I think it's good to go.