search

sensu / sensu-go

Simple. Scalable. Multi-cloud monitoring.
https://sensu.io
MIT License
1.02k stars 176 forks source link

new silenced setting attributes addition #5049

Open chavakula opened 8 months ago

chavakula commented 8 months ago

What is this change?

as per required mentioned in https://github.com/sensu/sensu-go-extras/issues/16

Why is this change necessary?

feature request mentioned in https://github.com/sensu/sensu-go-extras/issues/16

Does your change need a Changelog entry?

Do you need clarification on anything?

Were there any complications while making this change?

Have you reviewed and updated the documentation for this change? Is new documentation required?

How did you verify this change?

Done manual testing using available options to create silenced

  1. from UI interface
  2. using sensuctl create command
  3. using sensuctl create silence --interactive method

Is this change a patch?

fguimond commented 7 months ago

@chavakula Looks good! I believe this change requires a changelog entry.

chavakula commented 7 months ago

@chavakula Looks good! I believe this change requires a changelog entry.

Yes i guess,

@chavakula Looks good! I believe this change requires a changelog entry.

Hi @fguimond , i guess we require entry into changelog 6. any specific version planned to release?.

chavakula commented 7 months ago

@fguimond change log added. Please have a look if anything is required.