search

sensu / sensu-omnibus

Build full-stack platform-specific Sensu packages
12 stars 16 forks source link

Detect .NET version and install corresponding winsw variant #246

Closed cwjohnston closed 6 years ago

cwjohnston commented 6 years ago

MSI now determines whether .NET Framework version ==2.0 or >= 4.0 is available and copy the corresponding winsw executable in \opt\sensu\bin to sensu-client.exe.

~Installer now raises an error if no suitable .NET Framework is available.~ In keeping with prior installer behavior, no error is raised when .NET Framework is not available.

❤️ to @amdprophet for slogging through this with me!

Closes #234

cwjohnston commented 6 years ago

Installer now raises an error if no suitable .NET Framework is available.

Starting to second guess this part; feels like breaking change to a facet of our packaging public API. Thoughts?

cwjohnston commented 6 years ago

Also looking for guidance on which branch to land this change if we want to hold it off for 1.2

amdprophet commented 6 years ago

I agree that this has the potential to be a breaking change. PR should target master for a future 1.2 release.

cwjohnston commented 6 years ago

I removed the error being raised when .NET is not available. I think this ready to merge for inclusion in 1.2.