Check results silently dropped when the transport is down

sensu / sensu-transport

The Sensu transport abstraction library.

MIT License

14 stars 19 forks source link

Check results silently dropped when the transport is down #32

Closed moises-silva closed 7 years ago

moises-silva commented 8 years ago

No logging feedback (or any kind of feedback) is provided by the client socket interface (client/socket.rb) when a check is sent (e.g echo '{check data} | nc localhost 3030') and the transport is down (e.g reconnecting). The sensu client will reply with 'ok', so there's not even a chance we can retry later or even log on our side that something went wrong.

See also PR sensu/sensu#1352 as a use case where this issue prevents replying with a negative response to the HTTP request.

moises-silva commented 8 years ago

Created PR #33 which fixes this issue

portertech commented 7 years ago

Merged https://github.com/sensu/sensu-transport/pull/33