search

sensu / sensu-transport

The Sensu transport abstraction library.
MIT License
14 stars 19 forks source link

Buildup of RabbitMQ exchanges #53

Closed bodgit closed 6 years ago

bodgit commented 7 years ago

I have reasonable turnover of Sensu clients as machines are built and torn down and I've noticed on my RabbitMQ server(s) that I get a steady buildup of old client:* exchanges after machines have been deleted. Queues seem to be removed as these are marked as auto-delete but I was wondering if there was any particular reason exchanges aren't also declared with auto-delete?

As a workaround it should be fairly trivial for me to enumerate over the list of exchanges and delete any that don't have any bindings which is the telltale sign it's from an old client.

(Of course, the exchanges declared by Sensu are not marked as durable either so a restart of RabbitMQ or a reboot will clear everything out, eventually)

majormoses commented 6 years ago

https://github.com/sensu/sensu-transport/pull/54

annaplotkin commented 6 years ago

Closing this issue.

bodgit commented 6 years ago

I would say this isn't fixed. #54 would have fixed the issue however that's been dropped in favour of sensu/sensu#1828 which has also been postponed so currently there's no solution.

annaplotkin commented 6 years ago

Great point @bodgit ! I should have clarified, closing this issue in favor of tracking in 1828 not that the issue is fixed. Happy to re-open if that is preferable.

majormoses commented 6 years ago

@portertech I think we should reopen this or #54