search

sensu / uchiwa-chef

Other
33 stars 40 forks source link

Give the opportunity to manage the service another way #12

Closed webmat closed 10 years ago

webmat commented 10 years ago

Hey JF, I like runit, but I'm not a fan of the "runit sprawl" that's happening in all the cool community cookbooks. So I'm trying not to inflict that upon you ;-)

Do you mind having this flag, as a way to let people manage the uchiwa service their own way in their wrapper?

Another way this could be done is to split all concerns in their own recipe and have default be a simple list of include_recipe's. This way, when wrapping the cookbook it would be possible to include everything except include_recipe "uchiwa::service".

I can re-submit a PR like this, if you prefer.

failshell commented 10 years ago

Once you fix the failing test, and my comment, I'll be happy to merge this :)

webmat commented 10 years ago

Awesome thanks! Fixes are in.

Yeah I should have created a separate branch for my temporary version bump. Sorry about that!

failshell commented 10 years ago

I will release a new version this weekend. I need to revamp the tests first.