sensu / uchiwa-chef

Other
33 stars 40 forks source link

Default uchiwa.json config is broken #2

Closed aaduffy closed 10 years ago

aaduffy commented 10 years ago

The default configuration laid down by uchiwa-chef lacks port and path arguments. When uchiwa processes the config file the port and path become undefined. When uchiwa creates REST URLs these variables are interpolated as the string 'undefined' creating bogus URLs like "http://localhost:undefined" or "http://localhost/undefined/stashes".

The default configuration is defined in attributes/default.rb

# APIs Settings
default['uchiwa']['api'] = [
  {
    'name' => 'Sensu',
    'host' => '127.0.0.1',
    'ssl' => false,
    'timeout' => 5000
  }
]
palourde commented 10 years ago

@aaduffy Starting with Uchiwa 0.2.0, we now initialize undefined attributes so you won't face this issue.

aaduffy commented 10 years ago

@palourde, I see. Thanks. Actually that means the default attributes are still broken. Either the default uchiwa version needs to be bumped up to 0.2.0 or the API config needs to be altered. As-is one cannot get a server to stand up using the defaults and must dig through the code to figure out why the uchiwa log is complaining about a refused connection. Please consider my PR, or alternately please consider bumping the default version in the same attributes file.

palourde commented 10 years ago

@aaduffy The packages for 0.2.1 are not out yet, will do as soon it's released since I consider it's a bug with uchiwa and not the Chef recipe.