Repo installation is handled by uchiwa and sensu itself

sensu / uchiwa-chef

Other

33 stars 40 forks source link

Repo installation is handled by uchiwa and sensu itself #46

Open runningman84 opened 8 years ago

runningman84 commented 8 years ago

Right now, the sensu repo is added by the sensu-chef and the uchiwa-chef cookbook. This creates chef warnings and leads to other funny problems.

I would recommend these steps:

move the repo.rb to the sensu-chef cookbook
add a package.rb recipe to uchiwa-chef cookbook which installs only the uchiwa package itself
remove the repo handling from _linux.rb in sensu-chef cookbook

majormoses commented 6 years ago

Hmm the issue is that sensu and uchiwa cookbooks are meant to be decoupled and be able to run independently. I think that you probably should remove the repo.rb from your runlist if you are running both of them on the same instance. We might be able to inspect the collection of resources to conditionally assign it.

majormoses commented 6 years ago

I see that here we include the recipe so ya I see where you are coming from. I think what makes the most sense is to create custom resources that give you all of that functionality so you can decide how to implement it in your wrapper.

sspans commented 5 years ago

or use 'includepkgs' to only pull in sensu/uchiwa from a particular repo

majormoses commented 5 years ago

@sspans if you want to submit a PR I am open to it, I am going to be working on moving to sensu-go in a few months and I have not had issues with my existing setup. If someone wants to submit a PR I am all ears but I am not likely gonna spend any time looking into improving this.