Closed amdprophet closed 6 years ago
Merging #784 into master will decrease coverage by
0.05%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #784 +/- ##
==========================================
- Coverage 21.59% 21.54% -0.06%
==========================================
Files 28 28
Lines 2454 2460 +6
==========================================
Hits 530 530
- Misses 1859 1865 +6
Partials 65 65
Impacted Files | Coverage Δ | |
---|---|---|
uchiwa/daemon/clients.go | 52.3% <0%> (-5.32%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 815ad56...ee52a00. Read the comment docs.
Signed-off-by: Justin Kolberg amd.prophet@gmail.com
Description
Adds concurrency to the
buildClients()
method.Related Issue
N/A
Motivation and Context
The
buildClients()
method takes a significant amount of time to complete with a large number of clients & events. For example, with 18000 clients & events it was taking2m1.553801286s
to complete. With these changes it now takes21.951286761s
.How Has This Been Tested?
Added some log lines to benchmark performance. Started Uchiwa & verified data was still getting populated.
Screenshots (if appropriate):
Types of changes
Checklist: