sentanos / roblox-js

!!!THIS PROJECT IS NO LONGER MAINTAINED!!! Execute ROBLOX website actions in node.js
MIT License
45 stars 45 forks source link

getPlayers returning many duplicates #22

Closed iOSDevil closed 7 years ago

iOSDevil commented 7 years ago

Hi, firstly thank you for this really useful library.

I've been using it successfully for a while now but I think the group that I'm monitoring has become too large.

We have over 2,500 members and recently getPlayers started to return nearly 8,000 players. In this case there are only 420 unique users and each is duplicated 19 times.

The groupID is 3146600.

Is this a known issue?

many thanks

sentanos commented 7 years ago

This is due to a bug caused by a recent ROBLOX change. I patched this yesterday in cb96147 but forgot to publish it to npm. I've done it now and you should be able to use npm install to update the module to the latest version 3.0.6 which should fix the issue.

sentanos commented 7 years ago

This problem is reflected in v2 as well and in order to maintain compatibility with roblox-js-server that has also been patched in v2.3.7, if you happen to be using it you can update the dependencies with the second set of instructions here.

iOSDevil commented 7 years ago

Thanks for the fix, confirmed working.