sentayhu19
commented
2 years ago Thank you for your review and a great suggestions. I have updated the project based on what you suggested.
Sincerely
On Thu, Feb 10, 2022, 3:29 PM Robert Baiesita @.***> wrote:
@.**** requested changes on this pull request. Hi @sentayhu19 https://github.com/sentayhu19 , Good job so far on your portfolio!
- ✔ Correct use of Flexbox to display elements.
- ✔ No linter errors.
There are some issues that you still need to work on to go to the next project but you are almost there! Required Changes ♻️
- Please make sure you add meaningful messages to your commits, Update index.html is very generic and if you find a bug you won't be able to trace down what commit caused it because all the commit messages are the same. Keep this in mind for your future projects as it is a good practice..
Please check the comments under the review for more required changes. Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding! 👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.html https://github.com/sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/1#discussion_r803611880 :
In index.html https://github.com/sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/1#discussion_r803612656 :
+
+
+
- As this is a list of elements, I suggest you use an unordered list
tag, with each element being a list item that includes a link to your social media accounts.
In style.css https://github.com/sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/1#discussion_r803614356 :
+body {
background-image: url("assets/images/shapesbg.svg");
background-repeat: no-repeat;
+}
- [OPTIONAL] This will not be the only time you'll use a background image. Is is better to use background image styling on the single section and not the whole body, otherwise the image will be stretched as the project grows in size. Right now, this image is only required for the top section.
In index.html https://github.com/sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/1#discussion_r803616365 :
+
+
+
- Please make sure you're following the template's margin and padding. At the moment, you have two elements overlapping each other, kindly fix this issue and add a bit more margin to the elements to better match the template.
https://camo.githubusercontent.com/5f96204b001b31b660af1bf278ed5b7db477369108d75a70d4e1b8989e6ef325/68747470733a2f2f692e696d6775722e636f6d2f556a69305548732e706e67
In README.md https://github.com/sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/1#discussion_r803618808 :
+# sentayhu19-Portfolio-setup-and-mobile-version-skeleton
+
+# Portofolio
+
+> Desgining a portofolio
+
+## Built With
+
+-Lighthouse (An open-source, automated tool for improving the quality of web pages. It has audits for performance, accessibility, progressive web apps, SEO and more).
+-Webhint (A customizable linting tool that helps you improve your site's accessibility, speed, cross-browser compatibility, and more by checking your code for best practices and common errors).
+-Stylelint (A mighty, modern linter that helps you avoid errors and enforce conventions in your styles).
+
+
+# Getting Started
+
+#### Cloning the project
+
+git clone https://github.com/sentayhu19/portofolio-setup-nd-mobile-version-skeleton
+
+
+## Getting packages and debuging with Stylelint
+
+npm install --save-dev @. @. @. @.
+
+##### For validation detection using Stylelint Run
+
+npx stylelint "*/.{css,scss}"
+
+##### from parent source directory
+
+## Getting packages and debuging with Webhint
+
+npm init -y
+npm install --save-dev @.***
+
+##### For validation detection using Webhint Run
+
+npx hint .
+
+### Prerequisites
+##VSCode or any other equivalent code editor
+
+##node package manager
+### Licence
+MIT License
+##### from parent source directory
+Copyright (c) 2022 Sentayhu
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+
+
+
+## Author
Sentayhu Berhanu Robi - sentayhhu19
- Please make sure you stick to the Readme template https://github.com/microverseinc/readme-template/blob/master/README.md provided by Microverse for a professional documentation, you can edit your current Readme and fill it with the missing sections.
— Reply to this email directly, view it on GitHub https://github.com/sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/1#pullrequestreview-878751594, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASRE4363WH6G4RBHHHFS76LU2OVQZANCNFSM5OAHN2JQ . You are receiving this because you were mentioned.Message ID: <sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/1/review/878751594 @github.com>
sentayhu19
commented
2 years ago Thank you so much
Sincerely
On Thu, Feb 10, 2022, 9:35 PM Hamza Ellaouzi @.***> wrote:
@.**** approved this pull request.
Hi @sentayhu19 https://github.com/sentayhu19, Congratulations! 🎉 Project Approved ✅
Your project is complete! There is nothing else to say other than... it's time to merge it 🚀
To Highlight:
- The Pull Request has a proper title and description. ✔️
- You have added a descriptive Readme file. Good Job. ✔️
- There is no linter error is present. ✔️
- Project has met all the technical aspects you needed for this project! ✔️
Cheers and Happy coding and Keep rocking! 👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
— Reply to this email directly, view it on GitHub https://github.com/sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/1#pullrequestreview-879286585, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASRE437ZZIOD5CMTKHCN2PLU2QAPTANCNFSM5OAHN2JQ . You are receiving this because you were mentioned.Message ID: <sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/1/review/879286585 @github.com>
Html design of the portofolio and css styles for the elemenets of html and linters