sentayhu19
commented
2 years ago Hello @Wes-Isaac, Thank you for the great Suggestions I have updated it based on the comments you gave me .
Sincerely
On Sat, Feb 12, 2022, 12:39 AM Isaac @.***> wrote:
@.**** requested changes on this pull request.
Hi @sentayhu19 https://github.com/sentayhu19 ,
Impressive work so far! There are some issues that you still need to work on to go to the next project but you are almost there! 📝👌 Your project highlights 🔥😎
- Linters are on point ✔
- Splendid work with the README file 👀
- Proper use of GitHub flow 👌
- Awesome design 🙌
Required Changes ♻️
Check the comments under the review. Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider: n/a
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In style.css https://github.com/sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/2#discussion_r805011748 :
+.worksec1 {
position: static;
width: 88%;
height: 310px;
margin: 25px;
left: 50%;
top: 40%;
border-radius: 9px;
flex: none;
order: 0;
flex-grow: 0;
background: white;
padding-bottom: 142px;
padding-top: 76px;
+}
- Great job implementing this class 👍. However, it's one of the requirements, to use Flexbox to layout individual cards. Kindly fix this.
In style.css https://github.com/sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/2#discussion_r805015058 :
+.project1-btn {
position: static;
width: 110px;
height: 40px;
font-style: normal;
border-radius: 6px;
font-weight: 380;
font-size: 17px;
Great job implementing this class 👍. However, the button and list items on your site have a different design than that of Figma's. Your Implementation Figma Design [image: image] https://user-images.githubusercontent.com/59416136/153672275-394b840e-70b4-44e1-acb8-875c8ff10c59.png | [image: image] https://user-images.githubusercontent.com/59416136/153672368-940715d9-db3a-4275-bb6f-0cc5e86cae38.png
Kindly fix this.
In style.css https://github.com/sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/2#discussion_r805016892 :
+.discpara {
width: 295px;
height: 76px;
top: 92px;
color: #344563;
- Please use the same colour and font for the
tags in the card.
In index.html https://github.com/sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/2#discussion_r805020505 :
+
About
Myself+
Hello I’m a software developer! I can help you
build a product , feature or website Look through some of my work and experience! If you like what
you see and have a project you need coded, don’t hestiate to contact me.
Great job👍. However, these tags on your site have a different design than that of Figma's. Your Implementation Figma Design [image: image] https://user-images.githubusercontent.com/59416136/153673548-3f682acc-7e64-48f6-846b-491f921bdf71.png | [image: image] https://user-images.githubusercontent.com/59416136/153673602-2e8215ae-c466-4ea7-852e-f85352af0820.png
Kindly fix this.
In index.html https://github.com/sentayhu19/Portfolio-setup-and-mobile-version-skeleton/pull/2#discussion_r805021520 :
- CSS
- JavaScript
+
Work and about section are added to the index and style file