search

senthilrch / kube-fledged

A kubernetes operator for creating and managing a cache of container images directly on the cluster worker nodes, so application pods start almost instantly
Apache License 2.0
1.26k stars 119 forks source link

Feature: Build multi-arch image with windows support #156

Closed senthilrch closed 2 years ago

senthilrch commented 2 years ago

As a first step in supporting windows nodes in kube-fledged, build multi-arch images with windows support. Changes needed in Github action workflow.

akhilsahuji commented 2 years ago

Hey 👋 can you elaborate on this issue? I might be able to solve it!

senthilrch commented 2 years ago

All images built for kube-fledged are multi-arch images that support linux/amd64, linux/arm, linux/arm64. In order to support windows nodes we'll need to add windows/amd64 as additional architecture to the images. The images are currently built using Github action:- https://github.com/senthilrch/kube-fledged/blob/develop/.github/workflows/caller.yml

where the target platforms are set as below:- target_platforms: linux/amd64, linux/arm/v7, linux/arm64/v8

The target_platforms field will be used as input to following task in https://github.com/senthilrch/kube-fledged/blob/develop/.github/workflows/build-kube-fledged.yml

    - name: Build kubefledged-controller image
      uses: docker/build-push-action@v2
      with:
        context: .
        file: ${{ inputs.dockerfile_controller }}
        build-args: |
          ALPINE_VERSION=${{ inputs.alpine_version }}
          GOLANG_VERSION=${{ inputs.golang_version }}
        platforms: ${{ inputs.target_platforms }}
        push: ${{ inputs.push_image }}
        tags: ${{ inputs.controller_image_repo }}:${{ inputs.release_version }},${{ inputs.controller_image_repo }}:latest
sandeep-v1404 commented 2 years ago

Can I work on this issue?

senthilrch commented 2 years ago

Yes you can work on this issue

slawekww commented 2 years ago

@senthilrch Would you like to share any plans to have kube-fledged supporting Windows images? thx

pruthvibs164 commented 2 years ago

@senthilrch Can you please share more details on kube-fledged compatibility with Windows node.

  1. Can we cache on Windows nodes.
  2. If we can't, and need to cache on a Linux node, can the Windows node pull from the cache of a Linux node.
senthilrch commented 2 years ago

Duplicate of https://github.com/senthilrch/kube-fledged/issues/118 Hence closing this issue