Feature: Ability to pass labels/annotations to job pods

senthilrch / kube-fledged

A kubernetes operator for creating and managing a cache of container images directly on the cluster worker nodes, so application pods start almost instantly

Apache License 2.0

1.26k stars 119 forks source link

Feature: Ability to pass labels/annotations to job pods #217

Open NetanelK opened 1 year ago

NetanelK commented 1 year ago

Hi, currently we're running Istio on our clusters with istio-proxy sidecar injector. We would like to disable istio-proxy on kube-fledged cache pods.

Istio provides a custom label sidecar.istio.io/inject="false" which needs to be present on pod's metadata.

We'll need a way to pass those custom labels to kube-fledged, annotations can be done the same way. Another less preferred option is to deploy kube-fledged jobs into other namespace that imageCache resource namespace.

dyens commented 9 months ago

Hi, Maybe we can simply add sidecar.istio.io/inject="false" in https://github.com/senthilrch/kube-fledged/blob/master/pkg/images/image_helpers.go#L52 ? I can create pr for this.