search

sentier-dev / dds_registration

Django app for event registration and billing
MIT License
0 stars 1 forks source link

Improve secrets handling #67

Closed cmutel closed 7 months ago

cmutel commented 7 months ago
cmutel commented 7 months ago

@lilliputten Please give me a use case where you would want DEV but not DEBUG (or any other combination or these), the current code feels hackish and unmaintainable by others and certainly would not survive a code review from my partner. Putting too much into Django settings is in general not great practice - let's simplify the code and logic whenever we can.

lilliputten commented 7 months ago

@lilliputten Please give me a use case where you would want DEV but not DEBUG (or any other combination or these), the current code feels hackish and unmaintainable by others and certainly would not survive a code review from my partner. Putting too much into Django settings is in general not great practice - let's simplify the code and logic whenever we can.

Eg: It could be useful to keep dev mode on the server for a relatively long time during a bug investigation, but not turn on those internal django features. Though, not a really likely option, I agree.