search

sentinel-group / sentinel-rust

Sentinel Rust version
Apache License 2.0
128 stars 21 forks source link

chore: log error message instead of panic #125

Closed Millione closed 8 months ago

Millione commented 8 months ago

Corresponding issue https://github.com/sentinel-group/sentinel-rust/issues/8. I just fix it by simple logging it instead of unwrap. If we want throw out the errors to the API caller, I think there will be a lot of work and Trait API changes.

Forsworns commented 8 months ago

Yes, I think the trait should be revised, and as a lib, using concrete error crate, e.g., this_error, is a better choice than the current anyhow. Anyway, thanks for contributing :)