Upgrade Print Statements in Repository to Logging Or Remove them

sentinel-group / sentinel-rust

Sentinel Rust version

Apache License 2.0

128 stars 21 forks source link

Upgrade Print Statements in Repository to Logging Or Remove them #142

Closed flearc closed 6 months ago

flearc commented 6 months ago

There are some print statements in this repo which maybe used for debug, simply remove or wrap them use logging::debug!().

write_task
do_aggregate
rule_json_array_parser

Forsworns commented 6 months ago

Yes, these println should be removed.

As for the logger, in fact, it would be better to remove the realistic instantiation of the logger, since sentinel is an SDK. It should only use the abstract interfaces in log crate and remove the env_logger and log4rs impls. Maybe it's another huge topic worth a new issue...