Closed zigaLuksic closed 11 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
4b185cb
) 92.41% compared to head (4b185cb
) 92.41%. Report is 1 commits behind head on develop.:exclamation: Current head 4b185cb differs from pull request most recent head 9b2608a. Consider uploading reports for the commit 9b2608a to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
BTW, perhaps we should be adding to the changelog as we go along, not before each release.
I was thinking about it, but enforcing it seems like a drag compared to 5mins of staring at the history to come up with a condensed history.
I am willing to go with raise_on_temporal_dimension_mismatch
though it is long
raise_on_temporal_dimension_mismatch
Do you feel that the dimension
keyword is necessary? IMO it's clear enough to me, so I would drop it, but if you don't want to drop it, then I'm OK with the current name as well.
raise_on_temporal_dimension_mismatch
Do you feel that the
dimension
keyword is necessary? IMO it's clear enough to me, so I would drop it, but if you don't want to drop it, then I'm OK with the current name as well.
I am inclined to keep it because a temporal missmatch is also if the timestamps don't match, but we only check dimensions. But then again the docs do clarify it further :thinking: so maybe we can drop it
Do you think this might be useful?