sentinel-hub / eo-learn

Earth observation processing framework for machine learning in Python
https://eo-learn.readthedocs.io/en/latest/
MIT License
1.11k stars 300 forks source link

Add option to treat temporal warnings as errors in eoexecutions #760

Closed zigaLuksic closed 11 months ago

zigaLuksic commented 11 months ago

Do you think this might be useful?

codecov-commenter commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (4b185cb) 92.41% compared to head (4b185cb) 92.41%. Report is 1 commits behind head on develop.

:exclamation: Current head 4b185cb differs from pull request most recent head 9b2608a. Consider uploading reports for the commit 9b2608a to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #760 +/- ## ======================================== Coverage 92.41% 92.41% ======================================== Files 41 41 Lines 4300 4300 ======================================== Hits 3974 3974 Misses 326 326 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zigaLuksic commented 11 months ago

BTW, perhaps we should be adding to the changelog as we go along, not before each release.

I was thinking about it, but enforcing it seems like a drag compared to 5mins of staring at the history to come up with a condensed history.

I am willing to go with raise_on_temporal_dimension_mismatch though it is long

mlubej commented 11 months ago

raise_on_temporal_dimension_mismatch

Do you feel that the dimension keyword is necessary? IMO it's clear enough to me, so I would drop it, but if you don't want to drop it, then I'm OK with the current name as well.

zigaLuksic commented 11 months ago

raise_on_temporal_dimension_mismatch

Do you feel that the dimension keyword is necessary? IMO it's clear enough to me, so I would drop it, but if you don't want to drop it, then I'm OK with the current name as well.

I am inclined to keep it because a temporal missmatch is also if the timestamps don't match, but we only check dimensions. But then again the docs do clarify it further :thinking: so maybe we can drop it