search

sentinel-hub / sentinelhub-js

Download and process satellite imagery in JavaScript or TypeScript using Sentinel Hub services.
MIT License
52 stars 7 forks source link

Should module export dist files with cjs and mjs extrension #276

Closed janybravo closed 4 weeks ago

janybravo commented 4 weeks ago

Package should be more specific on what modules system is used on exported files extensions. Otherwise we'll get errors like this: 

Error [ERR_REQUIRE_ESM]: require() of ES Module ...\node_modules\@sentinel-hub\sentinelhub-js\dist\sentinelHub.cjs.js not supported. sentinelHub.cjs.js is treated as an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which declares all .js files in that package scope as ES modules.
Instead either rename sentinelHub.cjs.js to end in .cjs, change the requiring code to use dynamic import() which is available in all CommonJS modules, or change "type": "module" to "type": "commonjs" in ...\node_modules\@sentinel-hub\sentinelhub-js\package.json to treat all .js files as CommonJS (using .mjs for all ES modules instead).