search

sentinel-hub / sentinelhub-py

Download and process satellite imagery in Python using Sentinel Hub services.
http://sentinelhub-py.readthedocs.io/en/latest/
MIT License
798 stars 243 forks source link

Config no longer falsely loads profiles if file doesn't exist #486

Closed zigaLuksic closed 8 months ago

zigaLuksic commented 8 months ago

As noticed by you, if the file doesn't exist one could do the first initialization with SHConfig("something") and break the whole damn thing.

I added a test that now the first init fails for any non-default profile (since no such profile exists).

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3c4501c) 91.93% compared to head (3c4501c) 91.93%.

:exclamation: Current head 3c4501c differs from pull request most recent head 8e4cc4f. Consider uploading reports for the commit 8e4cc4f to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #486 +/- ## ======================================== Coverage 91.93% 91.93% ======================================== Files 55 55 Lines 4800 4800 ======================================== Hits 4413 4413 Misses 387 387 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonasViehweger commented 8 months ago

Looks good, thanks for fixing