search

sentinel-hub / sentinelhub-py

Download and process satellite imagery in Python using Sentinel Hub services.
http://sentinelhub-py.readthedocs.io/en/latest/
MIT License
798 stars 243 forks source link

Deprecate the deprecator #494

Closed zigaLuksic closed 8 months ago

zigaLuksic commented 8 months ago

The deprecator from typing_extensions has additional benefits of IDEs picking it up

image

I wanted to deprecate our own deprecators, but then users would get spammed with stuff that they have no control over (since it would happen on import. So I want to wait with that (or just remove them after a while)

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7fbdcd7) 91.95% compared to head (6f8cbb4) 91.95%. Report is 2 commits behind head on master.

:exclamation: Current head 6f8cbb4 differs from pull request most recent head d481afc. Consider uploading reports for the commit d481afc to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #494 +/- ## ======================================= Coverage 91.95% 91.95% ======================================= Files 55 55 Lines 4800 4800 ======================================= Hits 4414 4414 Misses 386 386 ``` | [Files](https://app.codecov.io/gh/sentinel-hub/sentinelhub-py/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentinel-hub) | Coverage Δ | | |---|---|---| | [sentinelhub/api/byoc.py](https://app.codecov.io/gh/sentinel-hub/sentinelhub-py/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentinel-hub#diff-c2VudGluZWxodWIvYXBpL2J5b2MucHk=) | `94.54% <100.00%> (ø)` | | | [sentinelhub/api/utils.py](https://app.codecov.io/gh/sentinel-hub/sentinelhub-py/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentinel-hub#diff-c2VudGluZWxodWIvYXBpL3V0aWxzLnB5) | `96.00% <100.00%> (ø)` | | | [sentinelhub/geometry.py](https://app.codecov.io/gh/sentinel-hub/sentinelhub-py/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentinel-hub#diff-c2VudGluZWxodWIvZ2VvbWV0cnkucHk=) | `85.92% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zigaLuksic commented 8 months ago

You plan to do a separate MR for preparing the release, right?

yes