search

sentora / sentora-core

Sentora is a web hosting control panel written in PHP for *NIX
GNU General Public License v3.0
653 stars 444 forks source link

Show/Hide password don't work for FTP #111

Closed MBlagui closed 9 years ago

MBlagui commented 9 years ago

Minor issue. Sentora 1.0.0 Showing/Hiding password for FTP password don't work under shadowing.or normal user.

TGates71 commented 9 years ago

I can confirm that it DOES WORK under zadmin (administrator). Show/hide works shadowing. Show/hide works user Using:


Server OS:
Ubuntu Icon Ubuntu
Apache Version:
Not found
PHP Version:
5.3.10-1ubuntu3.15
MySQL Version:
5.5.41-0ubuntu0.12.04.1
Sentora Version:
1.0.0
allebb commented 9 years ago

I can also confirm it's the same on Ubuntu 14.04.1 - Gotta be a jQuery/CSS issue for sure... I've not looked into it yet though!

On 2 February 2015 at 20:16, TGates notifications@github.com wrote:

I can confirm that it does work under zadmin (administrator). Show/hide works shadowing. Show/hide works user Using Ubuntu 12.04

— Reply to this email directly or view it on GitHub https://github.com/sentora/sentora-core/issues/111#issuecomment-72529230 .

TGates71 commented 9 years ago

So, it works for you Bobby or no? If it does work, then possibly a centos issue..?

MBlagui commented 9 years ago

This feature was introduced after we moved into RC guys... We should stop messing up front end once we are in RC.

Centos 6/7 don't work.

allebb commented 9 years ago

Nah... doesn't work bud.. I'm just installing another server atm but will fix for next release.

On 2 February 2015 at 20:39, MBlagui notifications@github.com wrote:

This feature was introduced after we moved into RC guys... We should stop messing up front end once we are in RC.

Centos 6/7 don't work.

— Reply to this email directly or view it on GitHub https://github.com/sentora/sentora-core/issues/111#issuecomment-72533098 .

TGates71 commented 9 years ago

Thats odd, as it works just fine for me. BTW, using firefox

allebb commented 9 years ago

.......Not for me lol!

On 2 February 2015 at 20:45, TGates notifications@github.com wrote:

Thats odd, as it works just fine for me.

— Reply to this email directly or view it on GitHub https://github.com/sentora/sentora-core/issues/111#issuecomment-72534109 .

TGates71 commented 9 years ago

Does NOT work on Chrome.

SoulTransfer commented 9 years ago

.. fix done.. Quite a bit of changes as the styles looked bad. My first commit to repository of someone else :)

5050 commented 9 years ago

It worked for Firefox (used along design) and probably with IE (because I'm used to test with both them, but I do not remember if I did with IE) but i'm sure I did not checked with chrome, opera and all others. My fault.

@SoulTransfer Before merging the new version, can you tell us with which browser you checked it, to ensure it continue to work with others than chrome ?

SoulTransfer commented 9 years ago

@5050 - one of the rasons for the refactoring and reimplementation in jQuery is the provided API-abstraction by the jQuery Framework. It ensures to have the same set of functions for all Browsers >IE8 (with jQuery 1.10) Therefore I would opt for reimplement "critical" functionality with jQuery...

I have tested it with the following browsers: password

allebb commented 9 years ago

Excelent great stuff, thanks SoulTransfer, I'll merge the changes now... IE7 in my opinion is way too old to worry about that not working! - People would have to be made to still be using that ;D

SoulTransfer commented 9 years ago

@bobsta63 - I'm happy to assist your project. About the IE7, yeah, absolutely correct, its no longer considered supportable as it would require a ot of effort to backport "modern" source code. But i just wanted to make sure that it is "just" not working, and nothing bad happens. (It shows the common jQuery problems but nothing additionally.)