search

sentora / sentora-core

Sentora is a web hosting control panel written in PHP for *NIX
GNU General Public License v3.0
648 stars 446 forks source link

DNS Manager: ipv6 AAAA records cannot be added to match existing A records #49

Closed trs998 closed 9 years ago

trs998 commented 10 years ago

If I have a A record for a host name, I cannot add a AAAA record with the same name

ERROR DNS NOT SAVED Hostnames must be unique.

Suggested fix: DNS record verification modified to ensure only CNAME records must not name-collide with A or AAAA records. All other records of different type but the same name are valid (TXT record could be named the same as a A or CNAME, for example)

Currently blocking ipv6 handling on the DNS server.

trs998 commented 10 years ago

Note that duplicate a and aaaa records are also valid, and a setting for the round-robin/cyclic setting would be nice. Bind should handle duplicate a and aaaa records happily anyway.

Caffe1neAdd1ct commented 10 years ago

Bug confirmed, we'll get back to you on which version we are planning to fix this in.

Feel free if you have time to fix this and raise a pull request, we are actively merging pull requests.

MBlagui commented 10 years ago

Duplicate AAA records should be allowed AS long they don't have same value.

allebb commented 9 years ago

Can anyone confirm if this is still an issue? - If so I'll look at getting this fixed in the next few days?

MBlagui commented 9 years ago

Still the case checked right now on last sentora.

I got error: ERROR DNS NOT SAVED

Hostnames must be unique.

Also I would notice all ip that are 192.168.x.x are rejected by DNS manager wich is totally crazy.

trs998 commented 9 years ago

Possibly it should warn for IPs in non-global Ip ranges (fe80, 10., 172.16., 192.168.) But it should accept them. There are many cases where this is perfectly valid.

N.b. I'm the original reporter - to get my local copy to work I just binned that existing-record check in the php validation, but ideally it needs to check same-type same-target record matches before reporting invalid record. Arguably this is actually also valid (round-robin with unequal server loads for example) but this is not something users of a shared hosting panel are likely to do. More commonly an exact matching duplicate record will be a mistake.

Tristan Scott On 19 Nov 2014 18:56, "MBlagui" notifications@github.com wrote:

Still the case checked right now on last sentora.

I got error: ERROR DNS NOT SAVED

Hostnames must be unique.

Also I would notice all ip that are 192.168.x.x are rejected by DNS manager wich is totally crazy.

— Reply to this email directly or view it on GitHub https://github.com/sentora/sentora-core/issues/49#issuecomment-63692971.

michelsup commented 9 years ago

This bug keep firing with 1.0.0 version.

MBlagui commented 9 years ago

yep still there

michelsup commented 9 years ago

I made a pull request solving this issue, but I do not believe it will be reviewed quickly, unfortunately.

allebb commented 9 years ago

Code reviewed - I've merged the changes - Sorry just been busy the last week!