search

sentora / sentora-core

Sentora is a web hosting control panel written in PHP for *NIX
GNU General Public License v3.0
653 stars 444 forks source link

DKIM DNS MySQL Truncation #52

Closed meakajon closed 9 years ago

meakajon commented 10 years ago

There is a problem with saving the DKIM Key to the TXT database Table.

Table [zpanel_core].[x_dns] [dn_target_vc] varchar(100)

Which is way to small for the encoded DKIM Key. Which is also still being lowercased in the PHP.

MBlagui commented 10 years ago

Likely this will be fixed in Sentora 1.1. We don't plan to make any changes in DB in 1.0.

Most DB changes are postponed to 1.1.

BUT we are aware of this error.

M B

meakajon commented 10 years ago

That makes sense, I was thinking about it last night. It would be great to develop the DNS so that it creates the DKIM key and SPF entries when you create the default DNS entries. Plus have opendkim installed as default with Sentora.

I will have a look at trying to code that up myself and put a pull request in. But very new to the code behind so playing catch up at the moment. Hints to the files that would involve would be appreciated, but sure I will find them.

On 24 September 2014 09:53, MBlagui notifications@github.com wrote:

Likely this will be fixed in Sentora 1.1. We don't plan to make any changes in DB in 1.0.

Most DB changes are postponed to 1.1.

BUT we are aware of this error.

M B

— Reply to this email directly or view it on GitHub https://github.com/sentora/sentora-core/issues/52#issuecomment-56642190.

allebb commented 9 years ago

Planning to get this fix and opendkim implemented in a separate branch (for testing) over the weekend.

allebb commented 9 years ago

After looking at the issue this morning, I've located the code in the existing Sentora master branch which appears to NOT be lower-casing the TXT target content so that should be ok now (lines 1104 - 1108 in modules/dns-manager/code/controller.ext.php)

For now, as increasing the DB column length isn't goign to have a massive impact on this release I'll do that to ensure that for the first release of Sentora the DKIM/TXT record truncation/limit is fixed.

allebb commented 9 years ago

After more investigation this evening I've found that @TGates71 has already increased the DNS target address length from 100 to 255 characters, I therefore believe that no further chages are required.

I'll close this bug for now as it should be ok in the latest beta release, if you can test and re-open this issue if you are still not able to add the TXT record.

heberth80 commented 9 years ago

I can confirm that the issue has been fixed on the RC3 I just installed. I used to fix it manually on zpanel.

allebb commented 9 years ago

Thanks for confirming the fix in RC3 :)

On 1 Feb 2015, at 00:27, heberth80 notifications@github.com wrote:

I can confirm that the issue has been fixed on the RC3 I just installed. I used to do fix it manually on zpanel.

— Reply to this email directly or view it on GitHub.