search

sentora / sentora-core

Sentora is a web hosting control panel written in PHP for *NIX
GNU General Public License v3.0
648 stars 446 forks source link

Sentora Config Icons per Row #75

Closed TheNigelist closed 9 years ago

TheNigelist commented 9 years ago

fifth option down in Sentora config is Icons per Row.

This no longer works with the new Bootstrap theme.

allebb commented 9 years ago

Good find! - I'll investigate... Probably time to take this out now that the theme no longer uses tables to display of the module icons ;) - I'll sort this out over the weekend! - If you can, assign this bug to me!!

On 22 October 2014 21:15, Nigel Caldwell notifications@github.com wrote:

fifth option down in Sentora config is Icons per Row.

This no longer works with the new Bootstrap theme.

— Reply to this email directly or view it on GitHub https://github.com/sentora/sentora-core/issues/75.

jasondavis commented 9 years ago

If memory serves me correct, I didn't use this option when I built the BS theme, probably good idea to either add in support or else remove the option

allebb commented 9 years ago

Yeah its no problem Jason :) - I think removal is probably the best bet to be honest, will stop people being tempted to use HTML tables for layout ;)

...I'll be working on a few of these 'issues' that I have assigned to me today and tomorrow so this should be closed shortly :)

allebb commented 9 years ago

After reviewing the changes and assessing the impact on existing themes out there, I've decided to simply change the system setting type to ensure that it is no longer visible to the user in the Configuration module (in affect deprecating the feature) but leaving the current value of '10' set in the database whilst theme developers are notified of the change on our mailing list (to ensure they can fix up their themes before the next release).

This change however is a SQL change only and therefore has been pushed over to the installers repository here: https://github.com/sentora/sentora-installers/commit/ff8f3212ec764346f351ddbafc12e3f109b085f9

At present the only obvious change is that the option is no longer available from the Sentora Config module (no longer user editable), in the next release we'll remove the setting entirely from the database.

Tested and is working fine in my development environment.