sentora / sentora-installers

Provides a central place to store, version and distribute the Sentora installer and upgrade scripts from.
GNU General Public License v3.0
153 stars 148 forks source link

Typo is setting local_ip to null when current machine ip is different to 127.0.0.1 #21

Closed bambusoft closed 10 years ago

bambusoft commented 10 years ago

The local_ip is setting to null value caused for a typo (adr must be addr) local_ip=$(ifconfig | sed -En 's|127.0.0.1||;s|.inet (adr:)?(([0-9].){3}[0-9]).|\2|p')

must be: local_ip=$(ifconfig | sed -En 's|127.0.0.1||;s|.inet (addr:)?(([0-9].){3}[0-9]).|\2|p')

Using: Installer version V1.0.0-beta2 Sentora github version 1.0.0-beta6 Sentora preconf version master

5050 commented 10 years ago

Damn ! it was addr and I turned it to adr when I discovered it did not worked on my VM, while asking myself why it worked before - am I crazy ? (- ok I'm because instead I would not be doing this installer !)

More seriously, I'm afraid that the word used depends on language or distrib ? As I do not want to parse all languages, I will accept first adr and addr. Thank you !