sentriz / gonic

music streaming server / free-software subsonic server API implementation
ircs://irc.libera.chat/#gonic
GNU General Public License v3.0
1.54k stars 110 forks source link

allow getCoverArt.view to be used without authentication #332

Open fucksophie opened 1 year ago

fucksophie commented 1 year ago

A way to use getCoverArt without passing my full password should be created.. I personally don't think the route should even have authenication.

When displaying your image anywhere else that isn't your own app, you have to upload the image that you get from getCoverArt and then use the URL the uploading service gave you instead, which is extremely bothersome, and uses more bandwidth.

fucksophie commented 1 year ago

This seems like an extremely easy addition.. Should I create a pull request?

sentriz commented 1 year ago

I'm not sure if that follows the subsonic spec. maybe you coudld ask on the @opensubsonic discussions

fucksophie commented 1 year ago

I'm not sure if that follows the subsonic spec. maybe you coudld ask on the @opensubsonic discussions

Yes, it doesn't. But this is a non-breaking change so I don't think it'd be a issue to add it into Gonic.