search

sentriz / gonic

music streaming server / free-software subsonic server API implementation
ircs://irc.libera.chat/#gonic
GNU General Public License v3.0
1.5k stars 105 forks source link

support getAlbumList2 `type=highest` #404

Closed GioF71 closed 8 months ago

GioF71 commented 8 months ago

Hello, thank you for your great software.

I am maintaining a subsonic client for upmpdcli: see here a slightly outdated changelog. I started with navidrome, and only recently I tried to update my work so that it could support Gonic as well. I have a small issue with the album title missing (available in 'name' however), which is a different behavior compared to navidrome, but no big issue there, I could work around this issue easily.

On the other hand I noticed that, while Navidrome supports "highest" as list type in the getAlbumList2 api method, Gonic doesn't seem to. I understand that, looking at the api documentation, that value should not be supported anyway, but considering that Navidrome supports it, is there a chance that Gonic can implement it?

Thank you for any feedback, all the best.

sentriz commented 8 months ago

oh i see. i'm not sure when highest became a thing, but yes it does seem to be part of @opensubsonic now. so sure i can add it :+1:

https://opensubsonic.netlify.app/docs/endpoints/getalbumlist2/

GioF71 commented 8 months ago

Awesome! Thank you!

sentriz commented 8 months ago

i added support for getAlbumList?type=highest and getAlbumList2?type=highest

also filled in the "album", "title" and "name" fields for subsonic albums in tags/folder modes :+1:

GioF71 commented 8 months ago

That worked perfectly! Thank you!