search

sentry-demos / empower

Monorepo for web app (Empower Plant) and its backend implementations in multiple languages/frameworks used in SE-demos, as well as for testing and sample events across the company. NOTE: used to be called "application-monitoring".
https://application-monitoring-react-dot-sales-engineering-sf.appspot.com/
2 stars 7 forks source link

[react] don't pre-fill checkout form for local TDA; flush replay after checkout #571

Closed realkosty closed 1 month ago

realkosty commented 1 month ago

when form is pre-filled and TDA attempts to type into it again, client-side email address validation fails (oddly you can't see it in session replay or even SauceLabs video recording - not sure why). This prevents checkout flow from completing successfully.

Testing

tested as part of https://github.com/sentry-demos/empower/pull/573

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.19%. Comparing base (f67ffa8) to head (36fed12). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
react/src/components/CompleteError.jsx 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #571 +/- ## ========================================== + Coverage 37.02% 37.19% +0.16% ========================================== Files 36 35 -1 Lines 813 812 -1 Branches 99 99 ========================================== + Hits 301 302 +1 + Misses 500 498 -2 Partials 12 12 ``` | [Flag](https://app.codecov.io/gh/sentry-demos/empower/pull/571/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos) | Coverage Δ | | |---|---|---| | [api](https://app.codecov.io/gh/sentry-demos/empower/pull/571/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos) | `7.85% <ø> (ø)` | | | [frontend](https://app.codecov.io/gh/sentry-demos/empower/pull/571/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos) | `57.38% <50.00%> (+0.32%)` | :arrow_up: | | [Components](https://app.codecov.io/gh/sentry-demos/empower/pull/571/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos) | Coverage Δ | | |---|---|---| | [checkout_module](https://app.codecov.io/gh/sentry-demos/empower/pull/571/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos) | `7.85% <ø> (ø)` | | | [product_component](https://app.codecov.io/gh/sentry-demos/empower/pull/571/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos) | `59.57% <50.00%> (+0.56%)` | :arrow_up: | | [Files with missing lines](https://app.codecov.io/gh/sentry-demos/empower/pull/571?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos) | Coverage Δ | | |---|---|---| | [react/src/components/Checkout.jsx](https://app.codecov.io/gh/sentry-demos/empower/pull/571?src=pr&el=tree&filepath=react%2Fsrc%2Fcomponents%2FCheckout.jsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos#diff-cmVhY3Qvc3JjL2NvbXBvbmVudHMvQ2hlY2tvdXQuanN4) | `22.41% <100.00%> (+1.36%)` | :arrow_up: | | [react/src/components/CompleteError.jsx](https://app.codecov.io/gh/sentry-demos/empower/pull/571?src=pr&el=tree&filepath=react%2Fsrc%2Fcomponents%2FCompleteError.jsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos#diff-cmVhY3Qvc3JjL2NvbXBvbmVudHMvQ29tcGxldGVFcnJvci5qc3g=) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/sentry-demos/empower/pull/571/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos)