sentry-demos / ios

iOS Empower Plant
1 stars 4 forks source link

Core data, HTTP Requests, Table #2

Closed thinkocapo closed 2 years ago

thinkocapo commented 2 years ago

Overview

The items in this table are pulled from the ios's local database. They'll get built out into full Product items in the future. There's also a http request for /products in the background, tested successfully.

Dev Notes

The nav butons are still there and clickable and functioning, but they're invisible (since the table got added). This will get fixed later. The green color backgrounds and fonts will get restored too.

The other screens (List App, Cart) still look fine (Style, Colors) when navigated to.

Confirmed we didn't miss any auto instrumentation on the UITableView:

That looks pretty good. The SDK has no automated instrumentation for table views or collection views as far as I can tell. The most important things to instrument would probably be cell creation as you did there in cellForRowAtIndexPath and also instrumenting how long it takes the table view to finish applying updates and re-render the view (this is more complicated to implement correctly, some swizzling will probably be needed)

image

Testing

Transaction still looks healthy Note the http request in it for /products

https://sentry.io/organizations/testorg-az/performance/will-cocoa:1bbf196667a24a6fa70629356b78de97/?project=6249899&query=transaction.duration%3A%3C15m&showTransactions=recent&statsPeriod=24h&transaction=EmpowerPlant.EmpowerPlantViewController&unselectedSeries=p100%28%29

image