sentry-demos / ios

iOS Empower Plant
1 stars 4 forks source link

Flagship Transaction: Needs Improvement #33

Closed kpujjigit closed 11 months ago

kpujjigit commented 1 year ago
image
armcknight commented 1 year ago

Here's an example in the dashboard: https://demo.sentry.io/performance/mobile-ios:9cfb3fbe69534110bebcd64a7f36b730/?project=6249899&query=&referrer=performance-transaction-summary&statsPeriod=1h&transaction=EmpowerPlantViewController&unselectedSeries=p100%28%29&unselectedSeries=avg%28%29

realkosty commented 1 year ago

Proposal from Oct 3 iOS Jam:

kpujjigit commented 1 year ago

@armcknight how goes development on the above action items?

kpujjigit commented 11 months ago

@kahest I think the last item we need to close this one out is to identify and instrument the missing instrumentation in our Flagship Transaction:

image

Example Transaction

kahest commented 11 months ago

@kpujjigit I didn't look into it closely, but I'm pretty sure that's the readCurrentDirectory - can you explain the purpose of this, and what the custom instrumentation should look like on the product?

kpujjigit commented 11 months ago

@kahest no further action needed here, this isn't a blocker so we'll leave it be. Thanks for chiming in.