sentry-demos / ios

iOS Empower Plant
1 stars 4 forks source link

Feature/add custom metrics #89

Closed serglom21 closed 6 months ago

serglom21 commented 6 months ago

Description

Add custom metrics to the Android demo app. These replicate the same metrics that were added to our react service here

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 37.655%. Comparing base (f5ab45b) to head (1b9c66a).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/sentry-demos/ios/pull/89/graphs/tree.svg?width=650&height=150&src=pr&token=2LCMV5RRHY&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos)](https://app.codecov.io/gh/sentry-demos/ios/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos) ```diff @@ Coverage Diff @@ ## master #89 +/- ## ============================================= - Coverage 38.627% 37.655% -0.972% ============================================= Files 10 10 Lines 787 802 +15 Branches 254 255 +1 ============================================= - Hits 304 302 -2 - Misses 474 492 +18 + Partials 9 8 -1 ``` | [Files](https://app.codecov.io/gh/sentry-demos/ios/pull/89?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos) | Coverage Δ | | |---|---|---| | [EmpowerPlant/AppDelegate.swift](https://app.codecov.io/gh/sentry-demos/ios/pull/89?src=pr&el=tree&filepath=EmpowerPlant%2FAppDelegate.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos#diff-RW1wb3dlclBsYW50L0FwcERlbGVnYXRlLnN3aWZ0) | `61.194% <100.000%> (+0.587%)` | :arrow_up: | | [EmpowerPlant/EmpowerPlantViewController.swift](https://app.codecov.io/gh/sentry-demos/ios/pull/89?src=pr&el=tree&filepath=EmpowerPlant%2FEmpowerPlantViewController.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos#diff-RW1wb3dlclBsYW50L0VtcG93ZXJQbGFudFZpZXdDb250cm9sbGVyLnN3aWZ0) | `61.172% <91.666%> (+1.248%)` | :arrow_up: | | [EmpowerPlant/CartViewController.swift](https://app.codecov.io/gh/sentry-demos/ios/pull/89?src=pr&el=tree&filepath=EmpowerPlant%2FCartViewController.swift&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos#diff-RW1wb3dlclBsYW50L0NhcnRWaWV3Q29udHJvbGxlci5zd2lmdA==) | `40.875% <0.000%> (-10.617%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/sentry-demos/ios/pull/89?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/sentry-demos/ios/pull/89?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos). Last update [f5ab45b...1b9c66a](https://app.codecov.io/gh/sentry-demos/ios/pull/89?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sentry-demos).
kpujjigit commented 6 months ago

Verified Flagship Issue - CodeCov Restored

image

Perf Issue Intact

image

Flagship Transaction & Dist. Tracing intact

image
kpujjigit commented 6 months ago

(Seems to be unrelated to this PR, disregard)

@serglom21 - Seeing 'unknown' for the flagship profile's recursion in this PR:

image
kpujjigit commented 6 months ago

Excellent App Starts and Screen Loads Deltas:

image image

PR Approved.