Fix of grouping logic - Githubissues

sentry-extensions / cyclops

Cyclops is meant to be a high performance barrier in front of Sentry (http://getsentry.com).

http://sentry-extensions.github.io/cyclops/

163 stars 15 forks source link

Fix of grouping logic #24

Closed WoZ closed 7 years ago

WoZ commented 8 years ago

After upgrading sentry-php from 0.12 to 1.5.0 I mentioned that amount of errors that were passed to sentry from cyclops dropped 100x times.

After research I've found that the reason was in updated sentry-php client. It sends culprit field equals to null and all the errors were grouped in the same way.

I checked clients for php, js and node and investigated formats they use. PR #25 contains logic that fits all clients and contains unit tests.

WoZ commented 8 years ago

BTW, responses from sentry-php and sentry maintainers:

getsentry/sentry#4588
getsentry/sentry-php#381

WoZ commented 7 years ago

Closed at #25