sentry-kubernetes / charts

Easily deploy Sentry on your Kubernetes Cluster
MIT License
1.09k stars 516 forks source link

What's the future of Clickhouse in this project? #1388

Closed chipzzz closed 3 weeks ago

chipzzz commented 2 months ago

How are we planning to manage Clickhouse in the future? The yandex version is deprecated and this project currently utilizes a custom helm chart that modifies the CH config. Are we planning to continue to utilize custom helm chart and utilize a modern Clickhouse image version or introduce a different community based CH helm chart that's maintained for us?

Mokto commented 2 months ago

I'm completely fine switching to another clickhouse version that is better maintained. It was more or less the only one available when I created this chart.

As long as a migration path is documented, we can do the switch.

TartanLeGrand commented 2 months ago

👀 : https://artifacthub.io/packages/helm/bitnami/clickhouse

chipzzz commented 2 months ago

@TartanLeGrand, I've used bitnami clickhouse before and reverted back to what this repo uses. When deploying clickhouse with replicas or shards the snuba migrations are very hard to manage. It becomes impossible to deploy and scale. I think using what self-hosted sentry uses may be the way since they at least try to follow sentry upstream. https://github.com/getsentry/snuba/issues/6174#issuecomment-2270031912

morsik commented 2 months ago

@chipzzz out of this topic, but... do you have any tips/docs regarding setting up Clickhouse with replication for Sentry?

Because I set replicaCount: 2 for Clickhouse in Helm Chart values, but sentry-snuba-metrics-consumer keeps crashing with:

snuba.clickhouse.errors.ClickhouseWriterError: Method write is not supported by storage Distributed with more than one shard and no sharding key provided (version 21.8.13.6 (official build))

So apparently it needs slightly more configuration anyway in order to make it working properly.

Mokto commented 1 month ago

This issue is stale because it has been open for 30 days with no activity.

Mokto commented 3 weeks ago

This issue was closed because it has been inactive for 14 days since being marked as stale.