Sentry external kafka breaks on install

sentry-kubernetes / charts

Easily deploy Sentry on your Kubernetes Cluster

MIT License

1.1k stars 517 forks source link

Sentry external kafka breaks on install #1584

Open nadecancode opened 4 weeks ago

nadecancode commented 4 weeks ago

Issue submitter TODO list

[X] I've searched for an already existing issues here

Describe the bug (actual behavior)

https://github.com/sentry-kubernetes/charts/pull/1557 breaks when there are multiple host / port that need to be specified.

Expected behavior

No response

values.yaml

Multiple externalKafka hosts / ports

Helm chart version

25.20.0

Steps to reproduce

Install with multiple kafka hosts & ports

Screenshots

No response

Logs

No response

Additional context

No response

reneeckstein commented 4 weeks ago

we just run into the same issue

patsevanton commented 4 weeks ago

FYI @MemberIT

MemberIT commented 3 weeks ago

@reneeckstein, @nadecancode Please provide an example of values.yaml to reproduce the issue.

nadecancode commented 3 weeks ago

@reneeckstein, @nadecancode Please provide an example of values.yaml to reproduce the issue. I don't have access to these with my personal device. But your build can fail with:

externalKafka:
  - host: xxx
    port: xxx
  - host: yyy
    port: yyy

Mokto commented 3 weeks ago

Could someone review the referenced PR please? Or even better, try it.

@nadecancode @patsevanton @reneeckstein

Thanks!

patsevanton commented 3 weeks ago

@reneeckstein @nadecancode PR is work. Could you try PR.