Closed senwu closed 2 years ago
Merging #117 (b417339) into master (17b5075) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 92.12% 92.13% +0.01%
==========================================
Files 40 40
Lines 2018 2021 +3
Branches 431 432 +1
==========================================
+ Hits 1859 1862 +3
Misses 94 94
Partials 65 65
Flag | Coverage Δ | |
---|---|---|
unittests | 92.13% <100.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/emmental/data.py | 91.74% <100.00%> (+0.23%) |
:arrow_up: |
Description of the problems or issues
On Mac with python 3.8+ multiprocessing uses
spawn
to start multiple process and it won't inherit from the origin process which causesMeta.config
is None. This resultsemmental_collate_fn
cannot getmin_data_len
andmax_data_len
fromMeta.config
.Description of the proposed changes
Instead get
min_data_len
andmax_data_len
fromMeta.config
inEmmental_collate_fn
, we set those two variables in theEmmentalDataLoader
.Test plan
Passes the existing test.
Checklist