search

seomoz / qless-core

Core Lua Scripts for qless
MIT License
85 stars 34 forks source link

Pub sub notifications #15

Closed myronmarston closed 11 years ago

proby commented 11 years ago

Fine with me. Is @dlecocq going to review?

myronmarston commented 11 years ago

@dlecocq and I already talked about this this morning. However, there are a couple additional changes I made that I didn't discuss with him: I changed the event names to code-identifier style strings rather than strings-with-spaces.

I'll hold off on merging this (the qless gem is already pinned to this commit so we can use it w/o merging) until Dan's ready to update his python client based on this.

myronmarston commented 11 years ago

Got the OK from @dlecocq, so I merged.