seomoz / qless-core

Core Lua Scripts for qless
MIT License
85 stars 34 forks source link

add pagination to worker counts, preserves backwards compatibility #42

Open wr0ngway opened 10 years ago

wr0ngway commented 10 years ago

With any significant number of workers (we have 1300, soon to be 8K+), workers.counts becomes unwieldy, especially in the qless ruby client's webui.

I tried to preserve backwards compatibility, so workers.counts without any args returns the entire set like it did before.

I also tried to match existing signatures that have pagination (e.g. offset, count as arguments).

However, as a result of the above two requirements (?) the QlessWorker.counts argument processing is a little hokey - basically I check wether the first arg is a number to determine wether the user intended to paginate all or get a single worker.