search

seomoz / qless-core

Core Lua Scripts for qless
MIT License
85 stars 33 forks source link

Add source recurring job #49

Closed myronmarston closed 10 years ago

myronmarston commented 10 years ago

@dlecocq -- here's the change we discussed. I was a bit surprised to see the value come through as False if it's not set, rather than the python equivalent of nil (apparently None?). Does that look right to you?

dlecocq commented 10 years ago

LGTM

myronmarston commented 10 years ago

Total side question, but I just noticed this bit of code:

    if interval <= 0 then
      error('Recur(): Arg "interval" must be greater than or equal to 0')
    end

(from https://github.com/seomoz/qless-core/blob/1c72256a7d27f5e246db1f6bdcad2cde3d2ee9be/queue.lua#L644-L646)

The conditional does not allow 0 but the error message says 0 is OK. Which is wrong? I'll update it while I'm in here.

dlecocq commented 10 years ago

Should be greater than 0. The error message is wrong.

myronmarston commented 10 years ago

Cool, I fixed that in a2f5603. I plan to merge when green. I'll have a qless gem PR ready in a few minutes.