search

seomoz / qless-core

Core Lua Scripts for qless
MIT License
85 stars 33 forks source link

Tagged recurring jobs aren't returned by tag get/top commands #52

Closed pintsized closed 3 years ago

pintsized commented 10 years ago

Perhaps this is by design, but I would have thought that "get" and "top" should return a union of ql:t and ql:r when searching for tags?

dlecocq commented 10 years ago

It's not by design per se, but originally tags were meant to apply to just regular jobs. You can apply tags to a recurring job, but that just controls how tags are applied to the jobs that are spawned from it.

I'm not sure off hand what technical issues might prevent heterogeneous get and top, but I'm not strictly opposed to it in principle.

pintsized commented 10 years ago

Ah, I see, I hadn't clocked that spawned jobs inherited the tags. Probably leave it then - I'm just writing a binding and came across the inconsistency when writing tests, but now I know what to test for. I don't need the feature specifically, and thinking about it, it could get confusing if both the parent and child jobs showed up in a tag search.